Back to board

Rider should still be paid the delivery fee on unsuccessful delivery

dinebd__mobileapp.rider#180

Description

Reported by client (WhatsApp) — business requirement

Even when an order is unsuccessful, the rider should still receive the delivery fee, and it should update in the income/dashboard.

Client request (verbatim): "Delivery unsuccessful hole-o rider should get delivery fee."

Scope: likely needs both API/business-logic change (credit the fee on unsuccessful delivery) and UI update (reflect it in income — see related real-time income issue). May touch dinebd__api.rider.

Comments (1)
Synced 10 Sept 2026, 05:35

kingRayhan

This was generated by AI during triage.

Code check (2026-07-18)

Reconfirmed the requirement: rider should earn delivery fee even when delivery is unsuccessful (customer not found → return to restaurant).

Current behavior

Income and invoicing only include DELIVERY_STATUS.DELIVERED:

  • dinebd__api.rider invoice.service.ts — invoice aggregation matches status: DELIVERED only
  • dinebd__api.rider report.service.ts — dashboard/total income also matches DELIVERED only

Unsuccessful path sets status to CUSTOMER_NOT_FOUND, then ITERM_RETURNED_TO_RESTAURANT — neither is included, so the rider gets ৳0 for that job.

Likely fix surface

Primary: graphland-dev/dinebd__api.rider (invoice + report queries). Rider app income UI should then reflect it automatically once API credits the fee.

Suggested payable statuses for unsuccessful-but-completed rider work:

  • ITERM_RETURNED_TO_RESTAURANT (and possibly CUSTOMER_NOT_FOUND if we credit earlier)

Board status is already In Review — no linked PR found yet.

Details
In ReviewGeneralopen
Repository
graphland-dev/dinebd__mobileapp.rider
Issue
#180
Author
kingRayhan
Created
14 Jun 2026, 12:53
Updated
9 Jul 2026, 12:28
enhancement